Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Middleware capability introduced #155

Merged
merged 1 commit into from
Jan 24, 2024
Merged

feat: Middleware capability introduced #155

merged 1 commit into from
Jan 24, 2024

Conversation

marcosschroh
Copy link
Collaborator

No description provided.

@marcosschroh marcosschroh marked this pull request as draft January 5, 2024 11:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024 •
edited
Loading

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-24 10:26 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3ae25c3) 95.54% compared to head (e472b0d) 95.87%.

Files Patch % Lines
kstreams/streams.py 96.42% 1 Missing ⚠️
kstreams/types.py 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   95.54%   95.87%   +0.32%     
==========================================
  Files          21       23       +2     
  Lines         786      848      +62     
==========================================
+ Hits          751      813      +62     
  Misses         35       35
Flag Coverage Δ
unittests 95.87% <97.84%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reidmeyer
reidmeyer reviewed Jan 8, 2024
View reviewed changes
examples/joker-middleware-example/README.md Outdated Show resolved Hide resolved
examples/joker-middleware-example/README.md Outdated Show resolved Hide resolved
examples/joker-middleware-example/README.md Show resolved Hide resolved
examples/joker-middleware-example/joker_middleware_example/app.py Show resolved Hide resolved
kstreams/middleware/middleware.py Outdated Show resolved Hide resolved
tests/middleware/test_middleware.py Outdated Show resolved Hide resolved
@marcosschroh marcosschroh force-pushed the feat/add-middelware-concept branch 7 times, most recently from fc875e6 to 829a03b Compare January 8, 2024 17:28
@marcosschroh marcosschroh marked this pull request as ready for review January 8, 2024 17:30
@marcosschroh marcosschroh force-pushed the feat/add-middelware-concept branch 2 times, most recently from fca5ef6 to 064dcf2 Compare January 12, 2024 12:10
woile
woile reviewed Jan 12, 2024
View reviewed changes
docs/middleware.md Outdated Show resolved Hide resolved
woile
woile reviewed Jan 12, 2024
View reviewed changes
docs/middleware.md Outdated Show resolved Hide resolved
woile
woile reviewed Jan 12, 2024
View reviewed changes
docs/middleware.md Outdated Show resolved Hide resolved
@woile
Copy link
Member

woile commented Jan 12, 2024

Excellent work 💪🏻 , really looking forward to this feature. I think it may be possible to implement windows through Middlewares in the future?

@marcosschroh marcosschroh force-pushed the feat/add-middelware-concept branch 6 times, most recently from 2761ef7 to 32eb9f2 Compare January 17, 2024 08:07
@marcosschroh marcosschroh force-pushed the feat/add-middelware-concept branch 2 times, most recently from 4b70c39 to cfdae6e Compare January 17, 2024 08:34
woile
woile approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@woile woile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 💪🏻

@marcosschroh marcosschroh force-pushed the feat/add-middelware-concept branch from cfdae6e to d79b27a Compare January 23, 2024 15:24
@woile woile mentioned this pull request Jan 24, 2024
Closed
@marcosschroh marcosschroh force-pushed the feat/add-middelware-concept branch from d79b27a to e472b0d Compare January 24, 2024 10:23
@marcosschroh marcosschroh merged commit d86bd1e into master Jan 24, 2024
8 checks passed
@marcosschroh marcosschroh deleted the feat/add-middelware-concept branch January 24, 2024 10:26
marcosschroh added a commit to marcosschroh/kstreams that referenced this pull request Jun 18, 2024
@marcosschroh
feat: Middleware capability introduced (kpn#155)
9486aac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidmeyer reidmeyer reidmeyer left review comments

@woile woile woile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosschroh @woile @reidmeyer